Individual Column Sorting and Filtering #59
+428
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Good afternoon~
- Filtering doesn't seem to work with the "Requirements" column on the Services page.
- A way to tell which columns are filtered without having to click through each column would be nice (maybe a filter icon or highlight on the column?)
I'm no longer on the Compass team, so this is just a comment (neither an approval or disapproval). Code quality looks fine, the comments I made are mostly nitpicks.
Collaborator
Author
|
Thanks for the review! |
naasanov
requested review from
SiddhantBorkar04 and
pmoharana-cmd
and removed request for
SiddhantBorkar04 and
pmoharana-cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ColumnHeadercomponent to handle the display of the column header and dropdown menusFilterDropdowncomponent for adding a filter to a column, with different dropdowns for filtering text versus tagsTagsInputcomponent to have the ability to be used as a filter, conditionally rendering a filter select component that changes filter method